[nnx] improve toy examples #3813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superbobry
reviewed
Apr 2, 2024
| counts_ = updates.extract(Count) | ||
| model = static.merge(params, counts) | ||
| y_pred = model(x) | ||
| _counts = model.extract(Count) |
There was a problem hiding this comment.
Why the _ prefix? It is normally used (by convention) to indicate that a variable is unused, but here this isn't the case.
There was a problem hiding this comment.
Should we keep counts_ then? Here we need a new variable name, cannot reuse counts.
There was a problem hiding this comment.
extracted_counts or new_counts?
cgarciae
force-pushed
the
nnx-improve-lifted-example
branch
from
05c5029
to
6d638e6
Compare
superbobry
approved these changes
Apr 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3813 +/- ##
==========================================
+ Coverage 60.86% 61.04% +0.18%
==========================================
Files 105 105
Lines 13045 13098 +53
==========================================
+ Hits 7940 7996 +56
+ Misses 5105 5102 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves toy examples, makes them more idiomatic according to current standards.